search

biemond / docker-database-puppet

Oracle Database 12.1.0.1 Standard Edition Docker image with puppet 3.7 on CentOS 6
19 stars 19 forks source link

Added conversion from the DOS-style line-endings to the unix-style #6

Closed wwarlock closed 9 years ago

biemond commented 9 years ago

Thanks but I think you can do dos2unix in 1 statement on linux

just do 

 dos2unix /startup.sh

and it's better to install dos2unix in the dockerfile (you also use it only in the dockerfile), you can add this to this line https://github.com/biemond/docker-database-puppet/blob/master/Dockerfile#L9

Thanks

wwarlock commented 9 years ago

Hmm, that's strange, I've tried "dos2unix /startup.sh" from command line and it doesn't execute, and no any symbols on STDOUT. So, I decide to convert as in patch. Ok, I'll try more.

biemond commented 9 years ago

strange

it should work like this ( the default ) dos2unix /startup or as this dos2unix -n in.txt out.txt

wwarlock commented 9 years ago

It looks like below

[root@d20a5b5c27c8 /]# dos2unix /startup.sh
dos2unix: converting file /startup.sh to UNIX format ...

I found dos2unix key -o, so I can use it.

[root@d20a5b5c27c8 /]# dos2unix -o startup.sh
dos2unix: converting file startup.sh to UNIX format ...
wwarlock commented 9 years ago

Could you please tell me why installing packages through the Dockerfile is better then through Puppet?

biemond commented 9 years ago

it is more you use dos2unix in the dockerfile but you install the package from the puppet site.pp , it is a bit hidden and when you remove it there the docker build will crash. Now it is together in 1 dockerfile

wwarlock commented 9 years ago

Yes, I agree