search

biemond / solaredge.modbus

Homey Solaredge modbus app
GNU General Public License v3.0
7 stars 8 forks source link

Expose n phases voltage #56

Closed BartSiedlarz closed 8 months ago

BartSiedlarz commented 8 months ago

I propose to add n phases voltage (L1-N, L2-N, L3-N) to SolarEdge inverter device. Something kinda similar was added recently to SolarEdge with battery device and I'm thinking that having this device capability may be very useful.

image

biemond commented 8 months ago

nice , only missing this migration part for current users https://github.com/biemond/solaredge.modbus/blob/main/drivers/invertor/device.ts#L66

BartSiedlarz commented 8 months ago

Ok I’m new with homey so thank’s for pointing this out, done https://github.com/biemond/solaredge.modbus/pull/56/commits/90dd56da16462070e6683091e502b6fad87883b8

On 13 Oct 2023, at 14:04, Edwin Biemond @.***> wrote:

nice , only missing this migration part for current users https://github.com/biemond/solaredge.modbus/blob/main/drivers/invertor/device.ts#L66

— Reply to this email directly, view it on GitHub https://github.com/biemond/solaredge.modbus/pull/56#issuecomment-1761404583, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALAZPOKY2SL3IP5K6L2O7HLX7EU43ANCNFSM6AAAAAA57AJF44. You are receiving this because you authored the thread.