search

biemster / FindMy

Query Apple's Find My network
225 stars 39 forks source link

Messed up pull request #11

Closed GabeBolton closed 1 year ago

GabeBolton commented 1 year ago

[Will be resumbitted after fixed] There are a huge number of possibilities for using the client to pull data down from the proxy, restructuring it as a class will make it more user friendly. I've reimplemented the existing mapping functionality as a subclass. These could be moved to an examples folder to demonstrate ways people can use the existing framework to write their own integrations.

This project is really perfect for getting reports into custom databases, so I think providing more flexible tooling will really help a lot of people.

biemster commented 1 year ago

Hi @GabeBolton , thanks for your interest in the project! Nice work on building this out and properly structuring it. However, this code is meant as a absolute minimum example of how to interact with the FindMy network, so I'm not planning on accepting any more PRs except bugfixes. That said, you are absolutely right that it would make the code more user friendly and easier to interact with, and most people will just want to push the reports to some db anyway, so feel free to create your own apps with it and promote that instead.