should parent and control prams on FieldConfig be optional

bietkul / react-reactive-form

Angular like reactive forms in React.

MIT License

309 stars 32 forks source link

should parent and control prams on FieldConfig be optional #38

Closed jfbloom22 closed 5 years ago

jfbloom22 commented 5 years ago

I am using the formGenerator extensively in my project along with typescript. Ran into warnings about the control and parent params missing when I upgraded to 1.0.29. However, it looks like they are not required (at least in FormGenerator.js). I simply updated the typings to reflect this.

jfbloom22 commented 5 years ago

awesome thanks for the fast merge!