search

bifrostlab / llm-assistant

Multifunctional LLM Assistant for Discord
8 stars 6 forks source link

Add python-3.12 devcontainer #16

Closed nqngo closed 8 months ago

nqngo commented 8 months ago

This PR add a Devcontainer environment for LLM-Assistant project. The base image used is mcr.microsoft.com/devcontainers/python:3.12.

This image is then rebuilt to add bash-completion and pre-install poetry as a dependency.

The accompanied CI job only runs when there are changes made to the .devcontainer dockerfile. Whilst devcontainer has the option of building the docker image on the host, preparing the image ahead of time allows us to cache and pin the version of poetry we are running.

The post-installation script will make sure the right virtualenv is selected when the container start. The provided devcontainer image has 2 platforms: linux/amd64 (Unix, Windows) and linux/arm64 (OSX)

nqngo commented 8 months ago

Wanna add a Code of conduct file as well?

sample: https://github.com/viet-aus-it/vait-discord-bot/blob/master/.github/CODE_OF_CONDUCT.md

Not in scope for this PR, will need to raise a separate PR. Hence why I keep the CONTRIBUTING.md minimal and did not specify conventional commit.

samhwang commented 8 months ago

Not in scope for this PR, will need to raise a separate PR.

Fair point, I didn't read the name of the PR