Closed hungdtrn closed 8 months ago
Add Ruff, pre-commit plugins to the VSCode devcontainer.
Add Ruff, pre-commit to dev dependencies.
Specify pre-commit to install on post-install step.
Update from python 3.10 to python 3.12.
Ensure the poetry.lock file is now consistent with pyproject.toml.
@nqngo can you clarify "Specify pre-commit to install on post-install step"? Do you mean that I should write a hook on "post-install" event for pre-commit install?
@nqngo I realized that the changes I made had already been done last night
@nqngo can you clarify "Specify pre-commit to install on post-install step"? Do you mean that I should write a hook on "post-install" event for pre-commit install?
My bad. The comment was around what has been done on my commit and not a task list. Just to clarify what I've setup.
Add a few scripts in the poetry config file to run ruff, so we can also run it manually.
Do you have any example of the custom script? I don't know why do we need to have some custom script for running ruff.
Do you have any example of the custom script? I don't know why do we need to have some custom script for running ruff.
Ignore my previous comment 😓 I had a look at poetry from the npm
world and thought we can define custom scripts so you don't have to type in poetry run ruff check .
repeatedly.
In pre-commit config, I use the following hook