search

bifurcationkit / BifurcationKit.jl

A Julia package to perform Bifurcation Analysis
https://bifurcationkit.github.io/BifurcationKitDocs.jl/stable
Other
288 stars 34 forks source link

BifurcationKit incompatible with latest ModelingToolkit version #121

Closed TorkelE closed 9 months ago

TorkelE commented 9 months ago

I think at least. This is a replicate of this issue over at MTK: https://github.com/SciML/ModelingToolkit.jl/issues/2284. I am unsure in which package it is easiest to fix this.

TorkelE commented 9 months ago

As mentioned by Sam in https://github.com/SciML/ModelingToolkit.jl/issues/2284, BifurcationKit has SciMLBase version < 2, with 2 being the latest version.

TorkelE commented 9 months ago

Had a chat with Avik who said that, given changes to some SciML packages, the best approach is to wait a week or 2 until that is fixed, and then look back at this.

rveltz commented 9 months ago

I would tend to think it is a no brainer to update but given the size of BK, I have to make sure the tests pass. Is there some info about the changes in SciMLBase?

TorkelE commented 9 months ago

Unsure about the SciMLBase changes. I thought it was easy, and tried to do so locally, but when I tried to run the tests I got incompatibility issues. My impression was that something downstream of BK affected something that indirectly was incompatible with SciMLBase 2.

rveltz commented 9 months ago

Can you ping me here please when Avik says it is good to try?

TorkelE commented 9 months ago

Will do. (I have some preliminary code, but the BifurcationKit/ModelingToolkit/Catalyst combination is currently on hold until this is ready)

TorkelE commented 9 months ago

This should be good now

rveltz commented 9 months ago

I tagged a new version that solves the issue.