search

big-band-roulette / musicians-portal-old

A portal for Big Band Roulette musicians built using Flask.
https://portal.bigbandroulette.com
0 stars 0 forks source link

Code formatting update #43

Closed carlashworth closed 11 months ago

carlashworth commented 11 months ago

When developing in jinja, I use a syntax highligher that provides best practice, and automatically lints, for that file type. Since we have been concurrently developing, this has picked up a lot of minor things, and I would like to sort these so that the code is cohesive.

Here are a few screenshots of the linter issues:

image

image

These should be easily fixable, but make developing bug free jinja a tad more difficult. If you don't mind me fixing them, I can make one pr sorting all files immediately?

THargreaves commented 11 months ago

Happy to fix these and use the longer going forwards. What is the VSC extension called?

Related, the reason why you don’t have new lines at the end of files might be that VSC defaults (against common practice) to removing trailing white space.

See https://m.youtube.com/watch?v=PnAhwKYhIjs to enable it.

carlashworth commented 11 months ago

The extensions are djLint, and Better Jinja - it's an auto linter so I think you have to install something, I can't remember, but the names are in the readme.

image

carlashworth commented 11 months ago

48ae623 solves this. Apologies for the bad naming...