Should not override Ctrl-P as it is ubiquitously used as the Up-arrow

bigH / git-fuzzy

interactive `git` with the help of `fzf`

MIT License

2.3k stars 42 forks source link

Should not override Ctrl-P as it is ubiquitously used as the Up-arrow #10

Closed aguadopd closed 3 years ago

aguadopd commented 4 years ago

Good work! I suggest not overriding Ctrl-P as it us usually used along with Ctrl-N to go Up and Down respectively. Relates to #7

bigH commented 3 years ago

these are the 3 commands that use Ctrl-P (no uses of Ctrl-N).

❯ rg 'Ctrl-P'
lib/modules/branch.sh
3:GIT_FUZZY_BRANCH_WORKING_COPY_KEY="${GIT_FUZZY_BRANCH_WORKING_COPY_KEY:-Ctrl-P}"

lib/modules/log.sh
3:GIT_FUZZY_LOG_WORKING_COPY_KEY="${GIT_FUZZY_LOG_WORKING_COPY_KEY:-Ctrl-P}"

lib/modules/reflog.sh
3:GIT_FUZZY_REFLOG_WORKING_COPY_KEY="${GIT_FUZZY_REFLOG_WORKING_COPY_KEY:-Ctrl-P}"

You can set these variables to choose whatever key you prefer.