Page/scroll up & down the right diff pane: needs keybinding configurability and in-app exposure

bigH / git-fuzzy

interactive `git` with the help of `fzf`

MIT License

2.31k stars 42 forks source link

Page/scroll up & down the right diff pane: needs keybinding configurability and in-app exposure #2

Closed ronjouch closed 3 years ago

ronjouch commented 4 years ago

When viewing a commit or a file in a commit (viewed with delta + bat), I couldn't find how to scroll down/up the diff in the right side of the screen (to view more than the first page of the diff). Here's what I intuitively tried:

PgDown, but it pages down the fzf cursor in the list of commits (left side)
Space/n/p/j/k, but it edits the query
Enter (thinking maybe I'd enter a mode of acting on the diff?), but it comes back to the main menu.

I'm sure there is a keyboard binding, but I couldn't find it, neither in the tool itself nor in the readme. It would be nice if it was explicitly listed in the top-left summary of the bindings (near∆ working copy Ctrl-P, ∆ merge-base Alt-P, etc.)

Thanks for the nifty tool! In particular, lack of delta/diff-so-fancy support in tig makes me like git-fuzzy 🙂.

zatnas commented 4 years ago

Shift-Up & Shift-Down

ronjouch commented 4 years ago

Shift-Up & Shift-Down

@zethnest thanks! Notes to maintainer or passerbys:

I cannot use these bindings, in my terminal both are bound to move between terminal panes...
... so, I'd love to be able to configure bindings ...
... and it might still be useful to explicitly list these kinda-unusual bindings in the top-left "self-documenting" summary (near ∆ working copy Ctrl-P, ∆ merge-base Alt-P, etc.).

dandavison commented 4 years ago

I found that mouse/trackpad scroll also does it.

sprytnyk commented 4 years ago

These shotcuts work too: Ctrl + e - scroll up Ctrl + y - scroll down

Navigation: Ctrl + k - go up Ctrl + j - go down

yermulnik commented 4 years ago

@vald-phoenix Kudos for ctrl + e and ctrl + y.

And +1 for an option to re-define these.

Also are there any keybinding to move right pane left and right as it doesn't wrap long lines.

sprytnyk commented 4 years ago

As for now, it looks like it's possible to redefine keybindings manually in the following files:

lib/modules/reflog.sh
lib/modules/log.sh
lib/modules/branch.sh
lib/modules/status.sh
lib/modules/hub/pr.sh
lib/core.sh

Also are there any keybinding to move right pane left and right as it doesn't wrap long lines.

As for that, this seems to be a primary limitaion of fzf by itself: https://github.com/junegunn/fzf/issues/756

bigH commented 3 years ago

the project has been updated to make the key bindings configurable. example