search

bigardone / phoenix-and-elm

Example application using Elixir, Phoenix and Elm
https://phoenix-and-elm.herokuapp.com/
189 stars 25 forks source link

CI, credo, formatting, etc #8

Open harlantwood opened 6 years ago

harlantwood commented 6 years ago

Hi, I've been working with your (great) project as I'm learning elixir. I've made some updates that may be of interest... others maybe not. Take a look and let me know if you'd like me to PR some of this back to you.

All of the formatting changes are tool generated, from mix format and elm-format. There are also some fixes suggested by credo.

Please ignore the crazy commit history, if I PR I'll make well formed commits of course.

https://github.com/bigardone/phoenix-and-elm/compare/tutorial/part-6...harlantwood:dev

harlantwood commented 6 years ago

It's also measuring test coverage btw: https://coveralls.io/github/harlantwood/phoenix-and-elm?branch=dev