Closed wucke13 closed 1 month ago
"Collective Intelligence" concluded that the file name would be better to make 71-CH341.rules
and remove the obsolete definitions MODE="0660", GROUP="plugdev"
.
@bigbigmdm No problem, I can adjust accordingly. Is there a changelog somewhere? This will become a breaking change, when we remove plugdev
. Hence it should be noted in the changelog/release notes.
New version was already released without update the changelog, anyway at least release notes is complete. I try to suggest again to have more extended and complete changelog (https://github.com/bigbigmdm/IMSProg/issues/19#issuecomment-2076780658) instead keep one line for version and incomplete even if is in dedicate file
@Fantu, let me delete the release. I'll do gbp import-ref -u1.4.1
and ask you to make a proper debian/changelog
. Do I need to somehow specify in the packaging that the old 99-CH341.rules
should be deleted?
Or is there no need to delete the release?
@bigbigmdm Don't delete the release, don't have important issue and now the project is followed and used by many people and distro, so is better to avoid bad things. Changelog improvements can be done now (also improving some old version entries) and for newer version but without override the latest release/tag.
About Debian packaging: udev rules is not in /etc so don't require maintscript to remove the old entry (like was for old .dat when was in /etc) about d/changelog this is a relevant change that can be good to notify, next d/changelog entry can be for example something like:
* New upstream version
- Renamed udev rule from 99-CH341.rules to 71-CH341.rules (for uaccess)
and removed deprecated MODE=660 and GROUP+=plugdev
* Fix debian/watch
@Fantu , please help to write a correct debian/changelog
file.
I suppose should start from something like:
imsprog (1.4.1-1) unstable; urgency=medium
* New upstream version
- Renamed udev rule from 99-CH341.rules to 71-CH341.rules (for uaccess)
and removed MODE=660 and GROUP+=plugdev
* Fix debian/watch
@Fantu, are previous records required:
imsprog (1.3.9-1) unstable; urgency=medium
* New upstream version (Closes: #1070883)
* Update debian/copyright
* d/control: add qttools5-dev to build-deps
* d/rules: add all hardening
* Bump debhelper compat to 13
* Bump Standards-Version to 4.7.0, no needed changes
-- Mikhail Medvedev <e-ink-reader@yandex.ru> Mon, 13 May 2024 15:09:18 +0300
imsprog (1.3.2-1) unstable; urgency=medium
* Initial release (Closes: #1057386)
-- Mikhail Medvedev <e-ink-reader@yandex.ru> Mon, 26 Feb 2024 13:16:51 +0300```
yes all are uploaded version (https://tracker.debian.org/pkg/imsprog/news/) so must be keeped
Thank you, @Fantu ! I'm finally starting to understand something. :)
This was already fixed by 947320fca4878b46beefbee05e47279c3b27f94e, hence this PR is obsolete.
@wucke13 , Yes, thank you for your help!
I have changed these files. You can check the changelog in the latest release. If you can check the German translation - I would be glad. (Please see here and here).
I did so, find my results here: https://github.com/bigbigmdm/IMSProg/pull/102
@wucke13 , thank you! Can you also check the desktop and metadata files: IMSProg_programmer/other/IMSProg.desktop IMSProg_programmer/other/IMSProg_editor.desktop IMSProg_programmer/other/IMSProg_database_update.desktop
IMSProg_programmer/other/imsprog.appdata.xml /IMSProg/blob/main/IMSProg_programmer/other/imsprog.database.update.appdata.xml IMSProg/blob/main/IMSProg_editor/other/imsprog.editor.appdata.xml
This fixes #98. Essentially, the processing of udev rules in lexical order rendered the
TAG+="uaccess"
in the IMSProg udev rule useless. This commit fixes it by renaming the rules file, causing it to be processed before the internal handling of udev'suacccess
.