search

bigbinary / neeto-ui-rn

A component library for React Native from BigBinary.
https://neetoui-rn-docs.onrender.com/
4 stars 2 forks source link

Improve paddings of Input field. #489

Closed sangameshsomawar closed 1 year ago

sangameshsomawar commented 2 years ago

Ref: https://github.com/bigbinary/neeto-chat-rn/issues/473

Tsudhishnair commented 2 years ago

@KiranRaj7 The above change requires change in the height of the Input component, based on this other similar components height also needs to be updated, like the multiselect etc. Please check and let me know how much height can be increased, and what other changes we need to do related to this in the other components.

KiranRaj7 commented 2 years ago

The problem occurs in smaller devices right? Let me check about the height but increasing height may cause the component h/w proportions. @Tsudhishnair

Tsudhishnair commented 2 years ago

@sangameshsomawar @KiranRaj7 Like discussed over the call putting this issue under hold for now.

Discussion notes from the call Since we have specified static values for padding and other spacings, the device is only scaling the font-size and keeping the spacing as it is thus giving a cluttered feel in the UI. In order to fix this we need to add lib like react-native-size-matters to scale all the values including the spacing based on the device size. Since this would be breaking change we will be doing this once releasing the v1 of all apps.