bigbinary / neeto-ui

A component library from BigBinary.
https://neeto-ui.neeto.com/
40 stars 3 forks source link

Design for pill needs to be more intuitive #516

Closed neerajsingh0101 closed 3 years ago

neerajsingh0101 commented 3 years ago

https://www.loom.com/share/ddecf15a2f584c9497299f22c10f8211

@vysaghsekharbb _a

vysaghsekharbb commented 3 years ago

The UI Kit has a green accent color. Let's use it to the active state.

Please find the design below

I will update the style In the UI Kit

++Praveen @praveen-murali-ind _a

Toggle

neerajsingh0101 commented 3 years ago

Looks good. Let's implement it.

praveen-murali-ind commented 3 years ago

@vysaghsekharbb Do we need to change the active state color in other UI components which follow similar pattern ?

Screenshot 2021-10-13 at 1 58 11 PM
praveen-murali-ind commented 3 years ago

@neerajdotname @vysaghsekharbb

If we update the active state color only to the Pill component, it will be weird in some scenarios. Consider a form layout, there may be components like checkboxes and radios. If we change the active color to green only for Pill, Pills may gain/lose focus which may not be good.

If we change the active state color to green for all similar components, we may lose the advantages of the monochrome design pattern.

We should consider a solution that preserves the monochrome design pattern and consistency.

@vysaghsekharbb _a

//cc @karthiknmenon

neerajsingh0101 commented 3 years ago

@praveen-murali-ind sure. We can explore within monochrome how to make active pill look like active. My issue with current design is that I thought couple of times that active pill is disabled.

vysaghsekharbb commented 3 years ago

I was experimenting with different designs patterns and discovered that using alien colours complicates the monochromatic design. Instead of using the green colour, I feel it is preferable to utilise the icons that indicate the enable and disable states. Please see the design solution given below.

@praveen-murali-ind @neerajdotname

image

neerajsingh0101 commented 3 years ago

@vysaghsekharbb this looks great and it gets the work done.

praveen-murali-ind commented 3 years ago

Let’s implement this.

@praveen-murali-ind _a