search

bigbio / proteomics-sample-metadata

The Proteomics sample metadata: Standard for experimental design annotation in proteomics datasets
GNU General Public License v2.0
76 stars 107 forks source link

Data without fractions #141

Closed foellmelanie closed 4 years ago

foellmelanie commented 4 years ago

Hi all,

thanks for your efforts to generate better metadata annotations :)

In the Experiment Design description I am missing an explanation on how to handle unfractionated data. Comment [Fraction Identifier] is included in the templates, therefore I assume one should not delete the column. So far I have decided to enter "1" for every dataset that has no fractions. Would it be more clear to write "not applicable"?

Maybe you can add one sentence to clarify this in section "3. From Samples to Assay (MSRun)".

Best, Melanie

ypriverol commented 4 years ago

Hi @foellmelanie :

Here some ideas.

Hi all,

thanks for your efforts to generate better metadata annotations :)

In the Experiment Design description I am missing an explanation on how to handle unfractionated data. Comment [Fraction Identifier] is included in the templates, therefore I assume one should not delete the column. So far I have decided to enter "1" for every dataset that has no fractions. Would it be more clear to write "not applicable"?

The best practices should be put 1 and this is what we are encouraging. You took the right way. I will add that to the documentation.

Maybe you can add one sentence to clarify this in section "3. From Samples to Assay (MSRun)".

Best, Melanie

ypriverol commented 4 years ago

@foellmelanie can you review this PR: https://github.com/bigbio/proteomics-metadata-standard/pull/143 it contains the documentation about the fractions.

foellmelanie commented 4 years ago

@ypriverol looks good