search

bigbio / proteomics-sample-metadata

The Proteomics sample metadata: Standard for experimental design annotation in proteomics datasets
GNU General Public License v2.0
76 stars 107 forks source link

Update the CI/CD to validate sdrf files on PRs #232

Closed ypriverol closed 4 years ago

ypriverol commented 4 years ago

We need to update the CI/CD in order to be able to validate PRs that contains sdrf changes or additions.

A prototype of the CI/CD has been built in CircleCI but is not working properly. Related issue: https://github.com/bigbio/proteomics-metadata-standard/issues/222

levitsky commented 4 years ago

I have a working Github Actions workflow already. I'm not submitting a PR yet because it doesn't make much sense to run it on every commit and trigger an email to all 17 watchers. I think it's better to fix all annotations first. And before that, we need to settle the mandatory columns and update the validator. I can submit the PR now, I'm just not sure now is the best time to merge it.

ypriverol commented 4 years ago

@levitsky I think it is extremely important to have the validation in place. People can put silence in the messages. Do your PR and I will merge it ;)

If the GitHub actions works, we can remove the CircleCI

ypriverol commented 4 years ago

@levitsky can we do some testing on it. I can't see the Github Actions workflow activated yet.

levitsky commented 4 years ago

It should show up after it is first triggered. And that would be by changing anything in the annotated-projects. Do you want me to do a PR just for testing?

I tested the workflow on my fork and locally, it worked for pushes. I didn't try PRs though.

ypriverol commented 4 years ago

Yes, please

levitsky commented 4 years ago

New workflow was triggered by #234 and failed expectedly. I'm not sure why CircleCI is still there, though.

ypriverol commented 4 years ago

I just stopped the CircleCI part. Hope will work now.