search

bigbio / quantms

Quantitative mass spectrometry workflow.
MIT License
24 stars 10 forks source link

Enable MBR in DIA-NN step #238

Open daichengxin opened 1 year ago

daichengxin commented 1 year ago

Description of feature

Now, due to make things as parallelisable as possible, Thus, step 2 consists of analysing each run separately with the in silico library generated in step 1. so we should think about adding MBR in one big node . See details: https://github.com/bigbio/quantms/issues/164

calizilla commented 11 months ago

Hi, this is marked as completed, but I don't see the --reanalyse parameter anywhere in the code. What was the strategy to implement MBR for parallelised DiaNN?

ypriverol commented 11 months ago

@calliza you are right. Let me re-open the issue.

michaelsteidel86 commented 7 months ago

Is this still considered as an open issue? To my understanding the re-analysis step based on the empirical library actually is an MBR -analysis. Please correct me if I am wrong. So --re-analysis is only required if full analysis (1st and 2nd pass) are being in one step (non-parallelized)

calizilla commented 6 months ago

Is this still considered as an open issue? To my understanding the re-analysis step based on the empirical library actually is an MBR -analysis. Please correct me if I am wrong. So --re-analysis is only required if full analysis (1st and 2nd pass) are being in one step (non-parallelized)

Yes I think you are correct, apologies for causing a re-open, I was new to DIA-NN at the time.