search

bigbio / sdrf-pipelines

A repository to convert SDRF proteomics files into pipelines config files
Apache License 2.0
16 stars 21 forks source link

[BUG] using unassigned variable in except block after failed assignment in try #121

Open fabianegli opened 2 years ago

fabianegli commented 2 years ago

Variables with failed assignment in a try block are not available in the corresponding exception.

https://github.com/bigbio/sdrf-pipelines/blob/cf2425d5767cddfaaae1b31d0385eef51eff6171/sdrf_pipelines/zooma/ols.py#L175

The logging here needs to either compose the url separately or use the variables used to compose the url. Or do both.

fabianegli commented 2 years ago

Wrong reasoning before, but still an issue.