search

bigbio / sdrf-pipelines

A repository to convert SDRF proteomics files into pipelines config files
Apache License 2.0
16 stars 21 forks source link

Why are these elements private? #141

Closed fabianegli closed 1 year ago

fabianegli commented 1 year ago

It seems to me to defy the purpose to make these elements private. https://github.com/bigbio/sdrf-pipelines/blob/babc93dd54f42507a35a5201eec1f11371feb915/sdrf_pipelines/openms/unimod.py#L27-L30

They seem to be intended for use. e.g. in https://github.com/nf-core/quantms/blob/0ca2cb5510d70cd8dddc125192dba7a50dca23a7/bin/prepare_diann_parameters.py#L49

ypriverol commented 1 year ago

Added the functions get for those properties. #148