bigbio / sdrf-pipelines

A repository to convert SDRF proteomics files into pipelines config files
Apache License 2.0
16 stars 21 forks source link

Conversion bruker data #148

Closed ypriverol closed 1 year ago

ypriverol commented 1 year ago
jpfeuffer commented 1 year ago

Can you add a "--version" command so we dont have to hardcode the version in workflows everytime and everywhere? Would be awesome

ypriverol commented 1 year ago

parse_sdrf.py --version give the version of the tool.

jpfeuffer commented 1 year ago

How can you specify that both raw and d are converted to mzml?

ypriverol commented 1 year ago

You mean having a conversion where you have more than one file type? Right now you will only have one file type to another, this is allowed: d:mzML or raw:mzML, d:d, etc.

jpfeuffer commented 1 year ago

what if you have multiple file types in the initial design?

ypriverol commented 1 year ago

We don't allow that in quantms or even OpenMS. I guess is a really future use case.

jpfeuffer commented 1 year ago

It is allowed in quantms. I ran pipelines with raw and mzml before.

jpfeuffer commented 1 year ago

If you only allow one type of raw file, why a mapping at all? Then you just need an option "out_type".

ypriverol commented 1 year ago

Ok, what will be the expected behaviour, something like:

raw:mzml d:d

Which mean convert the raw to mzml and keep the d as d?

jpfeuffer commented 1 year ago

Yes exactly.

ypriverol commented 1 year ago

What should happen if the user gives contradictory changes, like d:d and d:raw ? Error?

ypriverol commented 1 year ago

I will put the following behavior: --extension_convert 'raw:mzml, d:mzml' if multiple conversion options are provided for the same filetype: raw:mzml, raw:raw the tool will through an error.

ypriverol commented 1 year ago

@jpfeuffer the following commit allows multiple file conversions: https://github.com/bigbio/sdrf-pipelines/pull/148/commits/9c304a7a4dac617f231c1f4f251c5fb9d506caf4