search

bigbite / macy.js

http://macyjs.com/
MIT License
1.3k stars 156 forks source link

Breakpoint width measurement off. Doesnt take scrollbar into account #46

Closed adamrobinson closed 6 years ago

adamrobinson commented 6 years ago

It's proving hard to match up the breakpoint values in the plugin with CSS breakpoint values because of the way screen width is calculated.

Testing In Chrome the breakpoint in the plugin triggers 15px wider than the CSS media query (sizing window up). 15px seems to be the exact size of the scrollbar.

jrmd commented 6 years ago

Hey @adamrobinson

Sorry you're having issues with this, I have a fix in mind so I will do some tests and should have fix sorted by tonight

jrmd commented 6 years ago

Hey @adamrobinson this issue has been resolved in version 2.3.1

Let me know if you have any issues with the build.

adamrobinson commented 6 years ago

Thank you @jrmd for such a quick fix it’s really appreciated. Will test out the new version first thing in the morning.

adamrobinson commented 6 years ago

Works great now. Thanks.