Open thatisrich opened 1 week ago
Great point, thanks for raising this. I hadn't considered this scenario up until now.
I agree, it's confusing to clear styles that aren't currently part of what is editable within themer. Hopefully this will become less of an issue as we move forward and introduce more capabilities. But in the mean time, perhaps we should be limiting what is cleared when you hit that button.
In simple terms, this would be everything under the top-level styles
attribute in theme.json. settings
is where the colour palette, etc, is stored, which we don't yet support.
Behavior in question
After changing the theme Styles via the Editor, should clearing the customisations via Themer be restricted to only changes made in Themer or also cover changes made to the theme via the Editor panel?
For example, it's not currently possible to edit styles such as the colours in the palette via Themer, so clearing customisations of that type via Themer could be confusing.
This may be somewhat related to issue #99.
Some possible outcomes
Step-by-step reproduction instructions
Styles
icon at the top right of the screenAppearance > Styles Editor
clear all customisations
using theTools
dropdown at the top right of the screenEditor
and notice theStyles
changes are resetScreenshots, screen recordings, code snippets
Demo showing customisations being made via the Styles panel in the Editor, then cleared via Themer