bigbite / themer

GNU General Public License v2.0
2 stars 0 forks source link

[BBT-112] Prevent users from editing the preview #37

Closed Joe-Rouse closed 1 year ago

Joe-Rouse commented 1 year ago

Description

Completes BBT-112 - This PR adds the inert attribute to the div that surrounds the blocks preview. This means all user interactions (input, focus, hover etc.) on the element and its children aren't registered so the user can't edit the blocks in the preview.

The only concern for this approach is that it also removes the preview from the accessibility tree, but I don't think this is an issue as I don't think visually impaired users can use the preview anyway and they shouldn't be able to tab through the blocks in the preview.

Change Log

Steps to test

Screenshots/Videos

https://github.com/bigbite/themer/assets/45216035/5ec3531c-69e1-4637-8a4d-847182eea4a6

Checklist: