[bbt-55] Collapse Menu Link Behaviour

squarewave17 commented 6 months ago

Description

Fixes #55 - the 'collapse menu' link was changing size when Themer was open.

Change Log

Added a CSS rule to ensure the link stays at the right size

Steps to test

Just open up themer and check the 'collapse menu' link. The font size should remain at 13px

Note

The 13px font size is not uniform with the rest of the menu. The problem itself occurs because the font is not set in the same way that the other links use, it inherits the body font size which is somewhat janky of wordpress imo. Rather than modify themer css too much, the most elegant way to fix this was to just add a new rule.

Screenshots/Videos

http://bigbite.im/i/eKj6p8

Checklist:

[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

g-elwell commented 6 months ago

@squarewave17 thanks for this. This does fix the 'Collapse' button, but I wonder if we're patching over the bigger issue of CSS leaking outside of the themer preview. There could be other examples where this causes problems, so I feel like we should try to fix the cause otherwise we'd probably continue to see other similar instances crop up again.

squarewave17 commented 6 months ago

@squarewave17 thanks for this. This does fix the 'Collapse' button, but I wonder if we're patching over the bigger issue of CSS leaking outside of the themer preview. There could be other examples where this causes problems, so I feel like we should try to fix the cause otherwise we'd probably continue to see other similar instances crop up again.

Agreed, i'll take a closer look at it 🙏🏻

g-elwell commented 5 months ago

Closing as we'll address in #61

bigbite / themer