search

bigbite / themer

GNU General Public License v2.0
2 stars 0 forks source link

Add code editor #86

Closed squarewave17 closed 1 month ago

squarewave17 commented 3 months ago

What problem does this address?

Themer currently has limitations on what can and can't be edited.

What is your proposed solution?

Changing the theme.json preview into a code editor will give the user full control over theme.json

g-elwell commented 3 months ago

@squarewave17 I think this is a cool idea and worth investigating, but not as a priority for the v1.0.0 release of the plugin.

For v1.0.0 I'm happy for us to support editing theme styles only, and within that we should be able to support anything that is a valid attribute in the theme.json schema within the styles section.

Post v1.0.0 we should look at building on this to support editing theme settings which should cover the vast majority of use-cases for theme.json, and after that we could look at the other top-level theme.json attributes to consider whether it makes sense to support editing them via our UI.

I think introducing a code editor has some advantages, but it's not entirely in line with the purpose of the plugin (a UI for editing your theme.json file) and it is likely to increase complexity and raise more questions on how we want people to use the plugin, what the UX should be, etc.

I'm not closing the door on this entirely mind, I do think we should consider it at some point just not right now. Happy to leave this issue open for discussion as well.

g-elwell commented 1 month ago

Closing as not currently on the road map for themer