search

bigbite / wp-cypress

WordPress end to end testing with Cypress.io.
MIT License
86 stars 18 forks source link

Add support for docker compose plugin #131

Open markonikolas opened 7 months ago

markonikolas commented 7 months ago

Is your feature request related to a problem? Please describe.

I moved to docker compose plugin while back and removed the deprecated docker-compose standalone version from my machine. Using docker compose plugin gets you this error: docker-compose: not found

Describe the solution you'd like

I would like to see a support for docker compose plugin, and ideally remove deprecated docker-compose plugin.

Describe alternatives you've considered

I installed the standalone compose version so I can use the plugin for now.

Additional context

image

alvinchevolleaux commented 6 months ago

I think you can alias docker compose to docker-compose which should be a workaround for now.

markonikolas commented 6 months ago

@alvinchevolleaux this would only work as a function not an alias since we can't have a spaces in the command itself, but I still think this should be updated since the support for standalone docker compose was dropped in the July last year.

alvinchevolleaux commented 6 months ago

@alvinchevolleaux this would only work as a function not an alias since we can't have a spaces in the command itself, but I still think this should be updated since the support for standalone docker compose was dropped in the July last year.

The documentation states that there is an alias by default between docker-compose and docker compose since v1 is deprecated as you say but maybe that's out of date now? https://docs.docker.com/compose/migrate/#:~:text=From%20July%202023%20Compose%20V1,supported%20versions%20of%20Docker%20Desktop.

markonikolas commented 6 months ago

It seems like this only applies for docker desktop and not the docker engine.

With Docker Desktop, Compose V2 is always accessible as docker compose. Additionally, the Use Compose V2 setting is turned on by default, ...

alvinchevolleaux commented 6 months ago

It seems like this only applies for docker desktop and not the docker engine.

With Docker Desktop, Compose V2 is always accessible as docker compose. Additionally, the Use Compose V2 setting is turned on by default, ...

Ah yes you're right. It does make sense to be able to run without Docker Desktop I agree.