bigbluebutton / bbb-install

BASH script to install BigBlueButton in 30 minutes.
GNU Lesser General Public License v3.0
617 stars 538 forks source link

Ubuntu 18 Docker #371

Open maxjacobs283 opened 3 years ago

maxjacobs283 commented 3 years ago

I have noticed that the script will install docker-ce which is at version 20, however the official repository includes docker.io at version 20 aswell. As such it doesn't make sense to me why the script would rely on an external source. Also when I tried to install docker.io the script still force installed docker-ce over docker.io. I advice including a check for the already installed docker version or retiring the external repository in favor of the canonical repository to increase upgradability when a BBB for Ubuntu 20 releases.

paulmenzel commented 6 months ago

The same problem exists with the script for BBB 3.0.

Looking at the script, it explicitly looks for docker-ce (ce means community edition).

https://github.com/bigbluebutton/bbb-install/blob/26ce2d16c2a82ef962d685525b0c20bb89d4d151/bbb-install.sh#L1388-L1395

I also think, that Ubuntu’s packages should be used. Version 24.0.5 is even in the suite jammy-updates, if 20.10.21 should be too old.

jammy (22.04LTS) (admin): Linux container runtime [universe] • 20.10.21-0ubuntu1\~22.04.3 [security]: amd64 • 20.10.12-0ubuntu4 [ports]: arm64 armhf ppc64el riscv64 s390x jammy-updates (admin): Linux container runtime [universe] • 24.0.5-0ubuntu1\~22.04.1: amd64 arm64 armhf ppc64el riscv64 s390x