search

bigbluebutton / bbb-install

BASH script to install BigBlueButton in 30 minutes.
GNU Lesser General Public License v3.0
618 stars 539 forks source link

Add option to not install HAProxy + TURN in bbb-install-2.6.sh #593

Open ffdixon opened 1 year ago

ffdixon commented 1 year ago

We currently install HAProxy + TURN by default, but we should really only do this with the presence of an option.

Discussion in bigbluebutton-dev: https://groups.google.com/g/bigbluebutton-dev/c/tGX7xM3mL28/m/QegjIXOgAwAJ

lonesomewalker commented 1 year ago

What is the current status of this?

Currently in our test environment, we can se no haproxy nor TURN. But what we can see so far: the created turn-stun-servers.xml in /etc/bigbluebutton now contains no reference to our external STUN server (TURN is there).

This really needs some clarification.

I agree that it would be nice to have no TURN servers at all, but instead of implementing this not so well tested it would be fine to really have this optionally and somehow well-documented in docs.bbb

Thanks :-)

ffdixon commented 1 year ago

If you provide credentials to your own TURN server via -c, see

https://github.com/bigbluebutton/bbb-install/blob/master/bbb-install-2.6.sh#L59

BigBlueButton will not install a local TURN server + HAProxy. We could extend it to -c noturn:noturn so that if the user pass this string, the installer won't install TURN nor attempt to create/modify turn-stun-servers.xml.

What do you think?

lonesomewalker commented 1 year ago

In general: whenever it is documented (not only in the script) it is valuable for everybody :-) Also i have seen that there are some older references in the readme.md. I hope to find some time the next days to correct them.

The only issue i have so far... As you might have already noticed: i am not a fan of complicated systems. Keep them easy. Another 2 services on a BBB server gives just another layer of complexity and makes it harder to debug. But this is just my opinion.

What i have experienced: when i put my dedicated TURN server at the switch -c i get the TURN written to the xml, but STUN is missing. So, there seems to be a little bug about this -> will investigate when having time. (quick match in line 1254-1296 -> no STUN given)

ffdixon commented 1 year ago

So, there seems to be a little bug about this -> will investigate when having time.

Thanks!