bigbluebutton / bbb-install

BASH script to install BigBlueButton in 30 minutes.
GNU Lesser General Public License v3.0
615 stars 538 forks source link

illegal option -l #669

Open YouAreALegend opened 1 year ago

YouAreALegend commented 1 year ago

I saw in the document that only deploying certificates can use the - l parameter, but when I use this parameter, the command line will prompt an error: bash: illegal option -- l bbb-install: Invalid option: -

antobinary commented 1 year ago

Hey @YouAreALegend

Which version of BBB were you installing? Could you add here the full command (feel free to mask the email / domain)

YouAreALegend commented 1 year ago

BBB VERSION:2.6 wget -qO- https://ubuntu.bigbluebutton.org/bbb-install-2.6.sh | bash -s -- -v focal-260 -s XXX -e XXX@XX -l

ffdixon commented 1 year ago

There isn't a -I option in the installer.

https://github.com/bigbluebutton/bbb-install/blob/master/bbb-install-2.6.sh#L47

I saw in the document that only deploying certificates can use the - l parameter,

Can you post the link where you saw this option specified.

YouAreALegend commented 1 year ago

https://github.com/bigbluebutton/bbb-install/blob/2a58d62ba756b855b2476c3004516e2ce0912235/bbb-install-2.6.sh#L80

ffdixon commented 1 year ago

That is a lowercase L whereas you trying to pass a lowercase I.

antobinary commented 1 year ago

wget -qO- https://ubuntu.bigbluebutton.org/bbb-install-2.6.sh | bash -s -- -v focal-260 -s XXX -e XXX@XX -l

According to https://convertcase.net/ the above was a lowercase L, not an uppercase i. So from what I see @YouAreALegend is passing a valid -l command (lower case L)

ronator commented 12 months ago

Hi,

imho, the bbb-install script also in version 2.7.x is not considering any -l (lovercase L) switch. despite its documentation:

OPTIONS (install Let's Encrypt certificate only):

  -s <hostname>          Configure server with <hostname> (required)
  -e <email>             Configure email for Let's Encrypt certbot (required)
  -l                     Only install Let's Encrypt certificate (not BigBlueButton)
  -x                     Use Let's Encrypt certbot with manual dns challenges (optional)

As line 134 shows, OPT can never become lowercase L and will be handled as invalid input.

while builtin getopts "hs:r:c:v:e:p:m:t:xgadwjik" opt "${@}"; do

Since I was having troubles with certificates and BBB on AWS, I was wondering about that switch since it seems I must use LE certificates. The only two options are either to skip LE creation totally via -d switch or modify it via -x switch.

Can you clarify the differences between code and its documentation?

ronator commented 12 months ago

It seems, someone realized, that the -l switch never had any effect since the variable LETS_ENCRYPT_ONLY is not used in the entire script e.g. to have conditional behaviour. However, I was too lazy to follow the commits, since I cannot look before 2.5 branch in turnme and this one had the -l switch but except setting a variable, it does not affect anything.

https://github.com/bigbluebutton/bbb-install/blob/turnme/bbb-install-2.5.sh#L168C31-L168C31

ffdixon commented 12 months ago

Thanks for reporting this -- will take a closer look.

txt-file commented 4 months ago

What is the expected way to renew TLS certificates? Which CLI option does renew certificates

running ./bbb-install.sh -v focal-270 -s REDACTED -e REDACTED@REDACTED -l gives ./bbb-install.sh: illegal option -- l and the help screen. Am using v2.7.x-release branch.