bigbluebutton / bbb-install

BASH script to install BigBlueButton in 30 minutes.
GNU Lesser General Public License v3.0
615 stars 538 forks source link

Typo in script (rake instead of rails) blocking greenlight v3 fresh install with -g option #696

Closed ThomasMic closed 11 months ago

ThomasMic commented 11 months ago

After incomplete installation of greenlight v3 (rake aborted! Don't know how to build task 'secret') i think there is a typo on this line :

https://github.com/bigbluebutton/bbb-install/blob/38051114ebe6fa05aac622e048ab1ad1a7a34dbe/bbb-install.sh#L904

should be :

SECRET_KEY_BASE=$(docker run --rm --entrypoint bundle $GL_IMG_REPO exec rails secret)

not

SECRET_KEY_BASE=$(docker run --rm --entrypoint bundle $GL_IMG_REPO exec rake secret)

Thomas

ThomasMic commented 11 months ago

secret is not anymore in the rake task list when you do :

docker run --rm --entrypoint bundle bigbluebutton/greenlight:v3 exec rake --tasks

And in greenlight-release-3.0.8\sample.env (https://github.com/bigbluebutton/greenlight/blob/master/sample.env)

you can see this comment :

Verifies the integrity of all secrets created in the application Can be generated by running 'docker run --rm --entrypoint /bin/sh bigbluebutton/greenlight:v3 -c "bundle exec rails secret"

ffdixon commented 11 months ago

Thanks! https://github.com/bigbluebutton/bbb-install/pull/697

Ithanil commented 11 months ago

@ffdixon The fix needs to applied to bbb-install-2.6.sh as well.

ffdixon commented 11 months ago

Done. You can download the updated installer for 2.6 here https://raw.githubusercontent.com/bigbluebutton/bbb-install/master/bbb-install-2.6.sh. Also updated the remote version at https://ubuntu.bigbluebutton.org/bbb-install-2.6.sh