search

bigbluebutton / bbb-playback

GNU Lesser General Public License v3.0
29 stars 40 forks source link

Fullscreen doesn't use the browser's fullscreen API #155

Open mabeyj opened 3 years ago

mabeyj commented 3 years ago

Describe the bug The fullscreen toggle isn't truly fullscreen. The content area is maximized by hiding the sidebar and slide navigation (as expected), but the browser's fullscreen API is not being used. Browser and OS toolbars are still visible while fullscreen is enabled.

For comparison, BBB uses the fullscreen API, as did the old version of bbb-playback (that shipped with BBB 2.2). Currently, the user experience for fullscreen is inconsistent between live classes and viewing recordings.

To Reproduce Steps to reproduce the behavior:

  1. Click on the fullscreen button in bbb-playback to enable fullscreen

Expected behavior Browser and OS toolbars should be hidden while fullscreen, allowing bbb-playback to fill the entire screen.

Actual behavior Browser and OS toolbars are visible while fullscreen.

Desktop (please complete the following information):

pedrobmarin commented 3 years ago

It's done like that by design to avoid losing the player controls (video.js' controls bound with the webcams media) when setting the content fullscreen.

Although I'm not planning on changing this to use the browser native API anytime soon, I'll leave this open if someone is willing to make this happen.

hiroshisuga commented 3 years ago

The latest BBB 2.4RC3 does not use the browser's fullscreen function either.

pedrobmarin commented 3 years ago

The latest BBB 2.4RC3 does not use the browser's fullscreen function either.

Thanks for mentioning, @hiroshisuga .

I did know about that client change. For the playback case it was purely a technical/human limitation that moved me to avoid using the browser API. I just couldn't make things work without breaking stuff or losing important UI elements.

mabeyj commented 3 years ago

The latest BBB 2.4RC3 does not use the browser's fullscreen function either.

This option still uses the browser's fullscreen in 2.4RC3 (which seems to be intended: https://github.com/bigbluebutton/bigbluebutton/pull/12667#issuecomment-868430330):

image

Whereas the presentation fullscreen button does not (and the same for webcams and screen shares):

image

Toggling native fullscreen is a separate function from expanding the presentation or videos. What I like about this is that the user can have the chat/notes open while in native fullscreen.

The only thing missing from bbb-playback compared to BBB 2.4 is a button that toggles native fullscreen for the whole UI. The current fullscreen button functions the same as BBB 2.4 (expanding the presentation/video area without toggling native fullscreen). Something like this:

image

Though, it might be a bit confusing with the buttons being so close with the same icon. Another thing I find confusing (in BBB as well) is calling everything "fullscreen". In my opinion, "fullscreen" should only refer to browser native fullscreen and the other buttons should be "expand" or "maximize".

Mudassarali222 commented 1 year ago

@pedrobmarin please help me about [https://github.com/bigbluebutton/bigbluebutton/issues/18170] @hiroshisuga guided me using this [https://github.com/bigbluebutton/bbb-playback/issues/155] but its already opened issue.