search

bigbluebutton / bbb-playback

GNU Lesser General Public License v3.0
29 stars 40 forks source link

Bump tldraw to alpha.25 #279

Closed danielpetri1 closed 2 months ago

danielpetri1 commented 2 months ago

What does this PR do?

Upgrades the Tldraw version used by bbb-playback to v2.0.0-alpha.25.

Closes

https://github.com/bigbluebutton/bbb-playback/issues/277

antobinary commented 2 months ago

Hi @danielpetri1 ! Thank you for the PR! Here in one step you do: 1) upgrade tldraw* dependency 2) add "recharts" and "styled-components" dependencies 3) bump up the version of bbb-playback to be ready for tagging

Could you write a couple of notes about 2) please -- is this part of the "fix"? I would have thought that they'd only be needed in package-lock.json if they were transient dependencies needed by tldraw...

danielpetri1 commented 2 months ago

Hi @antobinary, thanks for already taking a look at the PR!

You're right that recharts and styled-components are needed by Tldraw to display the polls and are listed as dependencies there.

I did not expect to need to add them explicitly in package.json here, but without doing so I get the following message when deploying:

Failed to compile.

Module not found: Error: Can't resolve 'styled-components' in '/home/bigbluebutton/bbb-playback/node_modules/@bigbluebutton/tldraw/dist-esm/lib/shapes/poll/components'

Any ideas on why that could be? If I understood you correctly, they should be listed in package.json but not package-lock.json?

antobinary commented 2 months ago

I just checked in https://github.com/bigbluebutton/bigbluebutton/blob/v3.0.x-release/bigbluebutton-html5/package.json and I see the same 2 dependency added at the same level (parallel to tldraw in package.json). Good to go, thank you!