Correct Php-Version in '.scrutinizer.yml'?

DigitalTimK commented 10 months ago

I am not an expert in scrutinizer, but I saw that the environment has defined php 8.1 in .scrutinizer.yml. Since the current min-version of the bigbluebutton-api-php is php 7.4 (acc. to composer.json), wouldn't it be better to have scrutinizer changed to php 7.4 too?

GhaziTriki commented 9 months ago

@DigitalTimK I am all with you. While PHP 7.4 is the minimum we should remove supporting prior versions https://www.php.net/supported-versions.php. We can keep PHP 7.4 as minimum version for a while.

DigitalTimK commented 9 months ago

Hello @GhaziTriki,

I like to come back to the previous observed problem:

local computer runs php8.1
in composer.json the minimum php is defined with require.php: ">=7.4"
executing composer require tracy/tracy --dev installs Tracy v2.10 (but this version is not compatible to php7.4)
scrutinizer did not recognize this as a problem
risk of installation of other incompatible dependencies with every composer update

In order to avoid the installation of incompatible dependencies, I propose to add this into composer.json:

"config": {
  "platform": {
    "php": "7.4"
  }
},

See documentation that describes exactly this use case.

What do you think?

GhaziTriki commented 9 months ago

Hi @DigitalTimK

I don't think it is really an issue. I shared how composer handles dependencies install here https://github.com/bigbluebutton/bigbluebutton-api-php/pull/217#issuecomment-1951440992

Did I understand you well?

bigbluebutton / bigbluebutton-api-php

Correct Php-Version in '.scrutinizer.yml'? #214