search

bigbluebutton / bigbluebutton-api-php

Offical @BigBlueButton PHP API
https://github.com/bigbluebutton/bigbluebutton/
GNU Lesser General Public License v3.0
179 stars 198 forks source link

isMeetingExisting (new feature) #221

Closed DigitalTimK closed 6 months ago

DigitalTimK commented 7 months ago

This PR will introduce a new function (isMeetingExisting) to the BBB-Client to check weather a meeting is existing or not, since the function isMeetingRunning is checking if persons are in the meeting.

The PHP-Library is a "CLIENT"-tool which is using the API of BBB. This feature is creating added value to the users of this library.

GhaziTriki commented 6 months ago

I see your point @DigitalTimK.

As mentioned getMeetingInfo is the right API to use but the naming is confusing while isMeetingRunning is available. The purpose of the issue I opened on the core repository of BigBlueButton is for API consolidation.

We currently use isMeetingRunning API to check if the meeting has been created or not. However this API is old and does no more give use the accurate result we need. Instead developers do need to getMeetingInfo to check if the meeting is really alive or not.

There is no need to loop over the meetings to find the existing one getMeetingInfo should do the job. Creating a wrapper function should be the responsibility of the application integrator, keeping consistency with the API with its simplicity is more suitable for the developers.

DigitalTimK commented 6 months ago

Hey @GhaziTriki,

oh, understood. I removed the link to https://github.com/bigbluebutton/bigbluebutton/issues/8246. Based on this the iteration makes no sense. You're right.

But I think the function itself would add anyway some value to the users. So I adapted it. What do you think?