bigbluebutton / bigbluebutton

Complete open source web conferencing system.
https://bigbluebutton.org
GNU Lesser General Public License v3.0
8.56k stars 5.95k forks source link

Shared notes editor breaks when entering too long texts #17892

Open Ithanil opened 1 year ago

Ithanil commented 1 year ago

Describe the bug Pasting one very long (like 10000 words) or repeatedly pasting long (like 1000 words) bodies of text into the shared notes editor leads to an infinite loop of "Connected" popups and eventually to "You do not have permission to access this pad".

Using this method I have also managed to break the shared notes completely for the whole server for a certain amount of time, but I struggle to reproduce that at the moment.

To Reproduce Steps to reproduce the behavior:

  1. Generate a "lorem ipsum" text of 10000 words and store it in clipboard
  2. Open shared notes, paste text
  3. Observe the repeated "Connected" popups and potentially the message "You do not have permission to access this pad"

Expected behavior If entering too long texts is somehow an issue, it should be catched without crashing the editor for the user or potentially breaking the shared notes feature entirely for the conference or even whole server (?).

BBB version: BigBlueButton Server 2.6.6 (599)

KlausKnopper commented 1 year ago

It seems to matter how fast texts are inserted. Copying 8 x 1000 words sequential doesn't seem to trigger the behavior, while pasting 8000 words does.

Ithanil commented 1 year ago

Yes, it's about the rate of input, in terms of characters per second. If you paste 1000 words repeatedly in very quick succession, it does trigger the behavior. Doing the same with very short texts does not.

Ithanil commented 1 year ago

The corresponding issue in Etherpad repo: https://github.com/ether/etherpad-lite/issues/4951

Workaround is to increase "maxHttpBufferSize" in /usr/share/etherpad-lite/settings.json . Credits to @JeanPluzo for digging it out from the Etherpad issue.

JeanPluzo commented 1 year ago

I knew I saw the issue already. Thanks @Ithanil !

Sarrus commented 9 months ago

I've had this issue as well, many thanks for the workaround!

stale[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.