search

bigbluebutton / bigbluebutton

Complete open source web conferencing system.
https://bigbluebutton.org
GNU Lesser General Public License v3.0
8.41k stars 5.93k forks source link

Unintentionally published presentations #9465

Open frsteinb opened 4 years ago

frsteinb commented 4 years ago

Even those presentations uploaded and presented outside the overall RecordStatus events time range become parts of published presentations.

To Reproduce Steps to reproduce the behavior:

  1. start a meeting with the default presentation
  2. click recording button once to start intended recording
  3. click recording button again to stop intended recording
  4. now upload and present another presentation
  5. finish the meeting
  6. ensure the meeting gets processed by the "presentation" workflow

Expected behavior The second (uploaded) presentation should not be found in /var/bigbluebutton/published/presentation/MEETINGID/{presentation/,presentation_text.json}.

Actual behavior The second (uploaded) presentation is part of the published meeting. This could be regarded as a security concern, if confidential information gets presented while people assume, the recording will not get published. Video&Audio seems to be cut according to the intended time range.

Additional context Observerd on BBB 2.2.9.

frsteinb commented 4 years ago

I found this while I was working on a feature, we will need: Publishing a larger meeting as several parts based on multiple recording time ranges. Therefore, I expect to be able to supply a patch soon.

frsteinb commented 4 years ago

Pull request https://github.com/bigbluebutton/bigbluebutton/pull/9495 represents my attempt to fix this issue.

kepstin commented 2 years ago

It would be helpful if you could split out the changes for preventing presentations that aren't shown in the meeting from being processed out to a separate PR. That's a smaller and more likely to be accepted change than generating multiple recordings from a single meeting.