bigbluebutton / docker

Docker files for BigBlueButton
GNU Lesser General Public License v3.0
360 stars 242 forks source link

Cannot configure path for coturn certificates if HTTPS Proxy is disabled #137

Closed Zocker1999NET closed 2 years ago

Zocker1999NET commented 2 years ago

https://github.com/bigbluebutton/docker/blob/0dd3d9a0bc7ea3169e71f27246702f870a3607db/scripts/setup#L139-L140

The setup script does not allow users to set a correct path to the certificates for coturn as sed will interpret any slash / as end of a replacement. (my env is German, that's because sed's error is also in German):

Please enter path to cert.pem: /tmp/cert.pem                                                                                                                                                                                                                                                                                  
Please enter path to key.pem: /tmp/key.pem                                                                                                                                                                                                                                                                                    
Should a Prometheus exporter be included? (y/n): n                                                                                                                                                                                                                                                                            
Please enter the domain name: bbb.example.com                                                                                                                                                                                                                                                                              
Should the recording feature be included?                                                                                                                                                                                                                                                                                     
   IMPORTANT: this is currently a big privacy issues, because it will                                                                                                                                                                                                                                                         
   record everything which happens in the conference, even when the button                                                                                                                                                                                                                                                    
   suggets, that it does not.                                                                                                                                  
   make sure that you awalys get peoples consent, before they join a room!
   https://github.com/bigbluebutton/bigbluebutton/issues/9202                                                                                                  
Choice (y/n): n                                              
Is 109.193.183.143 your external IPv4 address? (y/n): y                                                                                                        
Is 2a02:8071:319b:b200:a696:4786:be72:7eed your external IPv6 address? (y/n): y
sed: -e Ausdruck #1, Zeichen 50: Unbekannte Option für »s«

sed's Error roughly translated: sed: -e expression #1, char 50, unknown option for »s«

mghadam commented 2 years ago

https://github.com/bigbluebutton/docker/pull/144