As I am currently about to deploy BBB on my server using this repository, I read through the docker-compose.tmpl.yml to better understand how the "dockerization" was accomplished, before deploying something unknown to me. I saw that most containers use network_mode: host. In my opinion a few minutes ago, the containers nginx and https-proxy do not require it and could instead use the internal docker network to forward the HTTP traffic, and use ports: - 443:443 (for https-proxy) or ports: - 8080:8080 (for nginx) to expose the required ports. This would even allow to easily modify the exposed port if e.g. 8080 is used elsewhere.
As I worked at a patch to this, I randomly found the PR #123, where I first read about the explanation, why it was built in the first way that these containers also use network_mode: host even if they require only one known port to be exposed. For the sake of future contributors, I propose that an explanation about this requirement will be documented with a comment in the docker-compose.yml.
Also, it would be great, if this could also be documented in the README as if I am not using the integrated HTTPS proxy, I never expected that BBB will listen to port 8080/tcp. If a machine might be used not only for BBB but for other services as well, it might be that this port will already be used by other applications, so a warning would be nice.
EDIT: The related issue #133 requests that 8080/tcp might be easily modifiable.
As I am currently about to deploy BBB on my server using this repository, I read through the
docker-compose.tmpl.ymlto better understand how the "dockerization" was accomplished, before deploying something unknown to me. I saw that most containers usenetwork_mode: host. In my opinion a few minutes ago, the containersnginxandhttps-proxydo not require it and could instead use the internal docker network to forward the HTTP traffic, and useports: - 443:443(forhttps-proxy) orports: - 8080:8080(fornginx) to expose the required ports. This would even allow to easily modify the exposed port if e.g.8080is used elsewhere.As I worked at a patch to this, I randomly found the PR #123, where I first read about the explanation, why it was built in the first way that these containers also use
network_mode: hosteven if they require only one known port to be exposed. For the sake of future contributors, I propose that an explanation about this requirement will be documented with a comment in the docker-compose.yml.Also, it would be great, if this could also be documented in the README as if I am not using the integrated HTTPS proxy, I never expected that BBB will listen to port 8080/tcp. If a machine might be used not only for BBB but for other services as well, it might be that this port will already be used by other applications, so a warning would be nice.
EDIT: The related issue #133 requests that 8080/tcp might be easily modifiable.