bigbluebutton / greenlight

A really simple end-user interface for your BigBlueButton server.
GNU Lesser General Public License v3.0
794 stars 3.8k forks source link

GL3 unusable after update from 3.2.0.2 to 3.2.1.4, if Help Center link was set before #5703

Closed Ithanil closed 8 months ago

Ithanil commented 8 months ago

After updating two (test) instances of GL3 from 3.2.0.2 to 3.2.1.4, they became unusable due to the "error page" rendering for the user after a few moments of being logged in. A third one, which had no Help Center link set, is not affected. In all cases, no Help Center link is displayed in the upper right corner drop-down.

Unfortunately, I can't find corresponding errors in the log and I didn't make it fast enough to the Site Setting to re-set the Help Center link. Resetting the Help Center link in the site settings does not seem to work.

Ithanil commented 8 months ago

In the site_settings table there are now two settings with the same setting_id:

 941fe4be-2d63-485f-98bd-3d5ade0965bd | 831d4ef5-5b30-41e7-9deb-def7ef5f3519 | https://www.redacted.net                                              | greenlight | 2023-12-21 07:22:17.135619 | 2023-12-21 07:25:02.261662
 7a6fb9a6-013f-4762-a4a7-8d9ef3796e9e | 831d4ef5-5b30-41e7-9deb-def7ef5f3519 |                                                                                         | greenlight | 2024-02-03 22:58:54.436945 | 2024-02-03 22:58:54.436945

Deleting the row with empty value fixes the issue.

I think the issue comes from db/data/20240125154727_add_help_center_setting.rb (https://github.com/bigbluebutton/greenlight/blob/08b5816dd7b5b6398f2ebc6e9b78e513da90f150/db/data/20240125154727_add_help_center_setting.rb) . The two find_or_create_by calls for the SiteSetting need to be replaced by a separate 'find' (without specifying value) and then a 'create' if not exists.

dirk-hl commented 8 months ago

I have the same problem. The error persists even if I downgrade to version 3.2.0.2.

Ithanil commented 8 months ago

@dirk-hl See my second comment for a solution.

farhatahmad commented 8 months ago

Yep - this migration has been a pain. I'll release a hotfix to deal with this (again)

farhatahmad commented 8 months ago

Fixed https://github.com/bigbluebutton/greenlight/releases/tag/release-3.2.2