search

bigbluebutton / greenlight

A really simple end-user interface for your BigBlueButton server.
GNU Lesser General Public License v3.0
787 stars 3.8k forks source link

Do not require email for signup with invite #5807

Open byteplow opened 2 months ago

byteplow commented 2 months ago

Currently, users must enter their email address when they sign up with an invitation. This email must match the email address for the invitation. This pr changes that so that users do not have to enter their email address:

  1. The email field is removed from the sign-up form when the registration method is invite.
  2. The user creation functions uses the email from the invite token.

Potential issue: The invite token is used as a unique index by itself. The documentations for has_secure_token states:

Note that it’s still possible to generate a race condition in the database in the same way that validates_uniqueness_of can. You’re encouraged to add a unique index in the database to deal with this even more unlikely scenario.

I lack the understanding of active recording to judge, if this is the problem in this case.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

farhatahmad commented 1 month ago

Thanks for this PR - this definitely improves the workflow for invited users. I'll try to get this into release 3.3.7