search

bigbn / drop-down-terminal-x

Drop Down Terminal X extension for the Gnome Shell
https://extensions.gnome.org/extension/1509/drop-down-terminal-x/?c=38764
GNU General Public License v3.0
91 stars 9 forks source link

still capture key bindings when not focused #30

Closed jakio6 closed 5 years ago

jakio6 commented 5 years ago

drop down terminal will capture keybinds for size changing when even when it was not on the drop down state

snaggen commented 5 years ago

This fix really only fixes half of the problem. By default you capture Alt+LeftArrow to move between tabs. This fix seems to avoid acting on the keypresses when not focused. However, you have till stolen Alt+LeftArrow globally, so no other application will ever see that key-press. And since Alt+LeftArrow is used as Back in numerous applications, this is BAD! I suggest you register/deregister the keyboard shortcuts when the window is shown/hidden, to avoid stealing all keypresses. You should only need to have one global shortcut registered to show/hide the window.