search

bigbn / drop-down-terminal-x

Drop Down Terminal X extension for the Gnome Shell
https://extensions.gnome.org/extension/1509/drop-down-terminal-x/?c=38764
GNU General Public License v3.0
92 stars 9 forks source link

Crashing when using custom colors #74

Closed brknkfr closed 3 years ago

brknkfr commented 4 years ago

Describe the bug Drop Down Terminal X is crashing when custom colors and not the system colors are enabled.

To Reproduce

  1. Go to 'Drop Down X Terminal Settings -> Colors' in the settings and disable 'system colors' checkbox.
  2. Try to open terminal with keybinding
  3. Crash (with a message, that I should enable debug mode)

Desktop (please complete the following information):

btw, where do I enable debug mode or how do I debug?

bigbn commented 4 years ago

journalctl -a | grep 'terminal-x\|JS-ERROR'

brknkfr commented 4 years ago

Here we go. Pressing the key combination for displaying the terminal.

Mai 13 21:44:33 sumsum gnome-shell[3378]: forking 'gjs /home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js /home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro'
                                  _createTerminalView@/home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js:790:7
                                  _createTerminalTab@/home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js:595:22
                                  addTab@/home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js:503:17
                                  _init@/home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js:265:5
                                  @/home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js:1229:18
Mai 13 21:44:34 sumsum gnome-shell[5079]: Script /home/sl/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/terminal.js threw an exception
bigbn commented 4 years ago

There are missing the exact reason of exception in this log. After the last line of provided logs the full exception description is available. Please find it via journalctl -a and post here

romgrk commented 4 years ago

There's no more info in those logs but running directly gjs terminal.js yields:

(gjs:1648766): Gjs-WARNING **: 03:58:22.742: JS ERROR: Error: Flat array of type RGBA is not currently supported
_createTerminalView@terminal.js:790:7

I'm guessing VTETerminal.set_colors(fg, bg, palette) isn't happy with palette's format.

From GJS commit: 5cb34600b13cfdbf101823a8636dc6469103e510 Tracking issue upstream: https://gitlab.gnome.org/GNOME/gjs/issues/44

Meanwhile, if you could make it possible again to set the fg/bg color even if setting the palette doesn't work would be nice.

brknkfr commented 3 years ago

Seems to work now, don't know why. I'm now on gnome-shell 3.36.5