search

bigbn / drop-down-terminal-x

Drop Down Terminal X extension for the Gnome Shell
https://extensions.gnome.org/extension/1509/drop-down-terminal-x/?c=38764
GNU General Public License v3.0
92 stars 9 forks source link

URLs should be clickable #85

Closed szarnyasg closed 3 years ago

szarnyasg commented 3 years ago

Describe the bug I'm curious how to make URLs clickable in Drop Down Terminal X.

To Reproduce Steps to reproduce the behavior:

  1. Open Drop Down Terminal X
  2. Run echo https://github.com
  3. The resulting text should be clickable.

I believe the links in the terminal should be clickable. For comparison, using the GNOME terminal, the string https://github.com:

In Drop Down Terminal X, the link doesn't get underlined and isn't clickable.

Expected behavior A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

Context I'm not sure if this is currently supported by Drop Down Terminal X. I found a related issue for Drop Down Terminal and it seems the URL handling code is present in this repository as well:

https://github.com/bigbn/drop-down-terminal-x/blob/9850f077d5b7ac0897c52c5893cd37e2e57a74cd/dist/terminal.js#L94

szarnyasg commented 3 years ago

I've upgraded to the code on master and it works now. Thanks!