bigbn / drop-down-terminal-x

Drop Down Terminal X extension for the Gnome Shell
https://extensions.gnome.org/extension/1509/drop-down-terminal-x/?c=38764
GNU General Public License v3.0
92 stars 9 forks source link

Crashes under Wayland #88

Open EvanWashkow opened 3 years ago

EvanWashkow commented 3 years ago

Describe the bug It appears that when starting a Wayland session that the extension crashes, with the error gdkDisplay is null

To Reproduce Steps to reproduce the behavior:

  1. Start a Wayland session
  2. Observe the problem

Expected behavior No error

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Error logs

Dec 01 13:05:20 xps-15-9550 gnome-shell[9736]: JS ERROR: Extension drop-down-terminal-x@bigbn.pro: TypeError: gdkDisplay is null
                                               _updateCurrentMonitor@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/extension.js:546:37
                                               enable@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/extension.js:271:10
                                               _updateWindowGeometry@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/extension.js:585:22
                                               throttle/func._throttlingId<@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/convenience.js:72:10
Dec 01 13:09:37 xps-15-9550 gnome-shell[12713]: JS ERROR: Extension drop-down-terminal-x@bigbn.pro: TypeError: gdkDisplay is null
                                                _updateCurrentMonitor@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/extension.js:546:37
                                                enable@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/extension.js:271:10
                                                _updateWindowGeometry@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/extension.js:585:22
                                                throttle/func._throttlingId<@/home/evan/.local/share/gnome-shell/extensions/drop-down-terminal-x@bigbn.pro/convenience.js:72:10
brknkfr commented 3 years ago

I have the same problem. Running on a multi monitor setup with https://extensions.gnome.org/extension/921/multi-monitors-add-on/.

I found a workaround, which is not really comfortable. You can remove the extension under https://github.com/bigbn/drop-down-terminal-x and re-enable it, then it's working again.

Somehow it seems, that gdkDisplay is not correctly initialized on a first login with multi-monitor?

Update: Disabling "Multi-monitor mode" in Drop-Down-Terminal-X helps.