bigcapitalhq / bigcapital

💵 Bigcapital is financial accounting with intelligent reporting for faster decision-making, an open-source alternative to Quickbooks, Xero, etc.
https://bigcapital.app
GNU Affero General Public License v3.0
2.46k stars 210 forks source link

Escaped data in text properties is displayed incorrectly #550

Closed oleynikd closed 1 month ago

oleynikd commented 1 month ago

Let's take Invoice as an example. I need to give my Invoice a custom number like "INV-00018/2" but as it gets escaped before storing I will get INV-00018/2 in DB. https://github.com/bigcapitalhq/bigcapital/blob/788150f80d47456c064ee543c3ee6f1ba141d7a3/packages/server/src/api/controllers/Sales/SalesInvoices.ts#L203 And when I open this Invoice in webapp I will also see INV-00018/2 The same behaviour is with all .escape-ed fields. We have to either skip escaping of those values, or add an unescape transformation before sending the data to webapp.

Screenshot 2024-07-30 at 12 00 45 Screenshot 2024-07-30 at 12 01 53
linear[bot] commented 1 month ago

BIG-224 Escaped data in text properties is displayed incorrectly

abouolia commented 1 month ago

Fixed it. Thanks for reporting.