bigcapitalhq / bigcapital

💵 Bigcapital is financial accounting with intelligent reporting for faster decision-making, an open-source alternative to Quickbooks, Xero, etc.
https://bigcapital.app
GNU Affero General Public License v3.0
2.58k stars 229 forks source link

S3_FORCE_PATH_STYLE does not work when domain instead of IP address #676

Open athiosh opened 1 month ago

athiosh commented 1 month ago

I have setup minIO container and was able to connect it with bigcapital. If I use ip:port for the endpoint, I am able to upload the file but I am not able to download the file unless I manually copy and paste the presigned_url in the browser. I think this might related to security issues but I am not sure how to resolve it. This is why I was trying to put my minIO behind NPM with a local domain and SSL, however whenever I use my local domain as the endpoint it would create virtual host style path instead of force path style. If this is a bug then hopefully it can get resolve, if not i just want to know if anyone has any idea on how to download the file if the endpoint is ip:port.

S3_REGION=US
S3_ACCESS_KEY_ID=<redacted>
S3_SECRET_ACCESS_KEY=<redacted>
S3_ENDPOINT=http://172.16.2.6:9033
S3_BUCKET=bigcapital
S3_FORCE_PATH_STYLE=true
Screenshot 2024-09-27 at 12 00 23 PM
S3_REGION=US
S3_ACCESS_KEY_ID=<redacted>
S3_SECRET_ACCESS_KEY=<redacted>
S3_ENDPOINT=https://minio-api.localhost
S3_BUCKET=bigcapital
S3_FORCE_PATH_STYLE=true
Screenshot 2024-09-27 at 12 00 30 PM

Brave browser version [Version 1.70.117 Chromium: 129.0.6668.59 (Official Build) (arm64)]

linear[bot] commented 1 month ago

BIG-256 S3_FORCE_PATH_STYLE does not work when domain instead of IP address