search

bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

CSS Error when using Luna Theme #109

Closed sepandgp closed 10 years ago

sepandgp commented 10 years ago

I am new to Dugway. I recently installed it on my PC and I am able to start it up using the default theme and configure it to use my Bigcartel Store. However, when I download and install the Luna theme so that I can customize it using Dugway I encounter problems with the themes.css stylesheet.

It appears that the CSS is not being properly compiled as I get the following error when I try to access http://127.0.0.1:9292/theme.css from my browser

undefined method `stringify_keys' for "#ffffff":String (in C:/BigCartel/soop/source/stylesheets/layout.css)

The specific line of code generating the error is line 7 in lib/dugway/liquid/drops/theme_drop.rb

I've played around with the CSS and JSON file and it appears to be a problem with the colors variables. If I comment out the colors entries in the CSS or change the name of the colors collection in the JSON file then that results in the CSS compiling correctly.

nickendle commented 10 years ago

Sorry for the trouble with this - there's currently an issue with duplicate variable names in Luna 1.2.x that's causing errors when generating the stylesheet. In settings.json there's a background variable for both the images and theme color settings.

We should have an updated version of Luna available soon that fixes this up, but in the meantime you may just want to temporarily change the background variable under the "colors" section of settings.json to something like background_color, and then replace any instances of theme.background with theme.background_color in your stylesheet.

sepandgp commented 10 years ago

Thanks for the speedy response, that workaround has fixed the issue for me.