bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

theme_image_url and theme_js_url don't work online #120

Closed timknapen closed 9 years ago

timknapen commented 9 years ago

{{ 'btn_website.png' | theme_image_url }} and {{ 'jsfilename' | theme_js_url }} work as described when developing with dugway locally, but can't be used when you add the theme to an actual working store online... This means that a locally working theme breaks when you use it in a real shop.

nickendle commented 9 years ago

@timknapen sorry, but since we don't currently support uploading a complete theme directly to Big Cartel from Dugway, it's not possible to have any images or javascript files hosted along with the rest of the theme. We mention that in the Known Issues & Limitations: https://github.com/bigcartel/dugway#known-issues--limitations

Rest assured it's something that we'll be tackling in the future to make things easier for theme devs.

timknapen commented 9 years ago

So I am correct in assuming those two functions as useless? If so, it's probably a good idea to mark them as such in your documentation on the website..

nickendle commented 9 years ago

@timknapen they're not entirely useless, since you'll still want to be familiar with the syntax when building and testing your theme in Dugway. We do point out in the beginning of our Dugway documentation that you'll need to host javascript and image files on a separate server when using the theme in an actual Big Cartel store. Apologies for the confusion!

timknapen commented 9 years ago

No need to apologise. But just to be completely clear about the two mentioned functions: they're only there because they will be supported in a possible future version. For now they are just an inconsistency between my local theme and the online version.. right?

nickendle commented 9 years ago

@timknapen exactly! :)

timknapen commented 9 years ago

Alright, thanks @deadformat! it's going to be so cool when Dugway and Bigcartel.com will be working together seamlessly.. hint hint :-)