search

bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

No ruby version specified #133

Closed jamelablack closed 8 years ago

jamelablack commented 9 years ago

Update gemfile to include ruby version or add .ruby-version file.

biscuitvile commented 9 years ago

I'm not 100% sure which we would prefer here to accommodate both RVM and Rbenv users. @syntaxritual do you have experience with this in a Gem context?

outerim commented 9 years ago

For a gem like this we kind of want it to be as portable as possible. The idea being that a user shouldn't have to worry too much about which version of ruby they are on, they can just run gem install dugway on their machine.

Ideally we would have a suite of tests run against several ruby versions to make sure that this works as intended.

outerim commented 9 years ago

Heh, in fact I just realized that our .travis.yml does specify three ruby versions 1.9.3, 2.0 and 2.1. This list should evolve over time as support for new versions is added and old ones are removed.