search

bigcartel / dugway

Easily build and test Big Cartel themes.
https://developers.bigcartel.com/api/themes
MIT License
149 stars 22 forks source link

Gemfile requirements #161

Closed Lerie82 closed 5 years ago

Lerie82 commented 5 years ago

I added two requirements I needed when I installed this repo,

brettchalupa commented 5 years ago

@Lerie82 Thanks for the pull request and contribution.

When you install Dugway via gem install dugway, various dependencies already require execjs. I think specifying therubyracer as a dependency is a good idea though, since folks who don't have an execjs runtime will need one.

If you're up for it, would you mind adjusting your PR to add therubyracer as a dependency in the gemspec? https://github.com/bigcartel/dugway/blob/master/dugway.gemspec#L21-L41 I'm happy to help if not.

brettchalupa commented 5 years ago

Closed by https://github.com/bigcartel/dugway/pull/166